Rework config.ini path handling
#761
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By default the config.ini should be searched in the same directory of the binary. If it's not found maybe could be in the parent of the binary, inside `Resources/` (we are on macos). Added also some logging. Use `go-paths-helper` to ease things.
…cos bundle integrity
cmaglie
commented
Feb 9, 2023
cmaglie
commented
Feb 9, 2023
cmaglie
force-pushed
the
config_ini_rework
branch
from
98129b9 to
ee31caf
Compare
cmaglie
force-pushed
the
config_ini_rework
branch
from
ee31caf to
67ce938
Compare
umbynos
approved these changes
Feb 9, 2023
cmaglie
added
type: enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please check if the PR fulfills these requirements
before creating one)
The
config.iniis no more part of the Arduno Create Agent package resources, but it is generated and saved in a user's home subfolder.In theory no. An old customized
config.inishould be detected and moved to the new correct location.